The dialog was something to read. Doesn’t sound like ai but rather something a developer has practiced for years and no one has challenged the dev on this, until now.
Also, there is discussions on what a commit message should contain, apparently the patch had user guidance in the commit message. Literally on how to install dependencies such as gcc using pacman, in the commit message.
I get maintainers have their own issues to deal with, and respect that they are trying to keep the project clean. At work I have had many times where I spent more of my day reviewing MRs than actually writing code, and sometimes my cold blunt replies can unintentionally rub people the wrong way.
Still, I feel like they were pretty rude to this guy for no real reason. I don't think I'd want to work with them.
Agreed. This reads more like a very junior dev reads static analysis warnings and extracts it into a constant to satisfy the ide. An LLM would at least give the constant a slightly abstracted name.
Yeah, I don’t think this is a case of ai slop. LLMs tend to be verbose with the comments but are fine with magic constants, at least from my experience.
Really? You think a git commit message in a C project is the right place to document how to install make and gcc on arch linux? That's not better suited as part of a readme file?
The dialog was something to read. Doesn’t sound like ai but rather something a developer has practiced for years and no one has challenged the dev on this, until now.
Also, there is discussions on what a commit message should contain, apparently the patch had user guidance in the commit message. Literally on how to install dependencies such as gcc using pacman, in the commit message.
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21595
I get maintainers have their own issues to deal with, and respect that they are trying to keep the project clean. At work I have had many times where I spent more of my day reviewing MRs than actually writing code, and sometimes my cold blunt replies can unintentionally rub people the wrong way.
Still, I feel like they were pretty rude to this guy for no real reason. I don't think I'd want to work with them.
const int EIGHT = 8 lol
I really doubt any AI (even some small local models) would actually generate something like this :)
Agreed. This reads more like a very junior dev reads static analysis warnings and extracts it into a constant to satisfy the ide. An LLM would at least give the constant a slightly abstracted name.
I've run into something akin to `const int EIGHT = 7`.
Courtesy of TCS.
Yeah, I don’t think this is a case of ai slop. LLMs tend to be verbose with the comments but are fine with magic constants, at least from my experience.
The xitter post consists of only a screenshot, a link, and a drive-by comment.
Here's the actual thing we're talking about https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21595#issuecomme...
I dont see problem with user manual in commit as long as reasoning for the commit is clearly written
Really? You think a git commit message in a C project is the right place to document how to install make and gcc on arch linux? That's not better suited as part of a readme file?
It should be in readme but I wouldn't complain if commit with new feature also had it
yeah, they seemed to be nitpicking there, better to focus attention on what someone's actually trying to commit